src/Migration/Sources/Appwrite.php (1)

951-977: Confirm whether spatial attributes can be arrays; constructors don’t accept array flag.

Other types pass array: $column['array']; spatial constructors don’t expose it. If Appwrite never returns arrays for spatial types, ignore. Otherwise, extend constructors to accept the array flag for consistency.

src/Migration/Resources/Database/Columns/Polygon.php (1)

13-15: Tiny style nit: extra spacing around type hints.

Let Pint normalize spacing.

Apply:

-        bool   $required = false,
-        ?array  $default = null,
+        bool $required = false,
+        ?array $default = null,

src/Migration/Resources/Database/Columns/Line.php (4)

1-3: Enable strict types.

Add declare(strict_types=1); for safer scalar coercions.

 <?php
+declare(strict_types=1);
 
 namespace Utopia\Migration\Resources\Database\Columns;

---

28-56: Fix docblock accuracy and clarify default shape.

• Mark createdAt/updatedAt as optional (you already default them).
• Consider documenting the expected geometry shape for defaults (e.g., LineString: array of [x,y] tuples, optional srid).

  /**
   * @param array{
      ...
-  *     required: bool,
-  *     default: ?array<mixed>,
-  *     createdAt: string,
-  *     updatedAt: string,
+  *     required: bool,
+  *     default?: array<array<float>>|null,  // e.g. [[x1,y1],[x2,y2],...], optional SRID via options/formatOptions
+  *     createdAt?: string,
+  *     updatedAt?: string,
   * } $array
   * @return self
   */

---

58-68: Harden fromArray: guard missing table/collection and coalesce optional fields.

Prevents undefined-index notices and produces a clearer error when table metadata is absent.

     return new self(
         $array['key'],
-        Table::fromArray($array['table'] ?? $array['collection']),
-        required: $array['required'],
-        default: $array['default'],
-        createdAt: $array['createdAt'] ?? '',
-        updatedAt: $array['updatedAt'] ?? '',
+        Table::fromArray($array['table'] ?? $array['collection'] ?? throw new \InvalidArgumentException('Missing table/collection for Line::fromArray')),
+        required: (bool)($array['required'] ?? false),
+        default: $array['default'] ?? null,
+        createdAt: (string)($array['createdAt'] ?? ''),
+        updatedAt: (string)($array['updatedAt'] ?? ''),
     );

---

8-9: Optional naming alignment with geometry terminology.

Consider LineString (or an alias) to match the underlying 'linestring' type and common GIS vocabulary. Not blocking.

Example alias (outside this file or in a small stub file):

<?php
namespace Utopia\Migration\Resources\Database\Columns;

class LineString extends Line {}

src/Migration/Resources/Database/Columns/Point.php (4)

1-3: Enable strict types.

Add declare(strict_types=1); for consistency and safer type handling.

 <?php
+declare(strict_types=1);
 
 namespace Utopia\Migration\Resources\Database\Columns;

---

28-56: Tighten phpdoc and describe expected default.

• Mark createdAt/updatedAt optional.
• Document expected default as a [x,y] pair (and optional srid if applicable).

  /**
   * @param array{
      ...
-  *     required: bool,
-  *     default: ?array<mixed>,
-  *     createdAt: string,
-  *     updatedAt: string,
+  *     required: bool,
+  *     default?: array{0: float, 1: float}|null, // [x,y], optional SRID via options/formatOptions
+  *     createdAt?: string,
+  *     updatedAt?: string,
   * } $array
   * @return self
   */

---

58-68: Make fromArray resilient to incomplete payloads.

Same hardening as Line: guard table/collection and coalesce optional fields.

     return new self(
         $array['key'],
-        Table::fromArray($array['table'] ?? $array['collection']),
-        required: $array['required'],
-        default: $array['default'],
-        createdAt: $array['createdAt'] ?? '',
-        updatedAt: $array['updatedAt'] ?? '',
+        Table::fromArray($array['table'] ?? $array['collection'] ?? throw new \InvalidArgumentException('Missing table/collection for Point::fromArray')),
+        required: (bool)($array['required'] ?? false),
+        default: $array['default'] ?? null,
+        createdAt: (string)($array['createdAt'] ?? ''),
+        updatedAt: (string)($array['updatedAt'] ?? ''),
     );

---

8-26: Optional: validate default geometry shape.

If you expect strict geometry shapes, consider normalizing/validating in the constructor or fromArray (e.g., ensure [x,y] floats for Point).

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/Migration/Resources/Database/Database.php (1)

15-17: Non-blocking: Avoid duplicating type constants; rely on Column::TYPE_ instead.*

These file-scope TYPE_POINT/TYPE_LINE/TYPE_POLYGON constants duplicate the Column class constants and can drift. Consider removing these and referencing Column::TYPE_* where needed.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro